Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add RISCV in test and build #3706

Merged
merged 52 commits into from
Apr 14, 2023
Merged

[CI] Add RISCV in test and build #3706

merged 52 commits into from
Apr 14, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Mar 24, 2023

Added RISCV in both test and build Actions

@ptitSeb ptitSeb enabled auto-merge (squash) March 29, 2023 10:57
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a thorough review, but I didn't notice anything problematic. LGTM.

Docker cross-compilation is always annoying...

.github/workflows/build.yml Show resolved Hide resolved
@ptitSeb ptitSeb disabled auto-merge March 29, 2023 17:37
@ptitSeb ptitSeb enabled auto-merge (squash) March 29, 2023 17:38
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Mar 30, 2023

The RISCV branch depend on using wapm-targz-to-pirita v0.2.0, but then, it need #3690 to be merge to be able to run all test without error (or else https://github.com/wasmerio/wasmer/blob/master/lib/wasi/src/runners/container.rs#L36 will be triggered)

@ptitSeb ptitSeb merged commit 01a8036 into master Apr 14, 2023
@ptitSeb ptitSeb deleted the ci_riscv64 branch April 14, 2023 08:46
.github/workflows/web.yaml Outdated Show resolved Hide resolved
.github/workflows/web.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants